[Kde-games-devel] Review Request: Adapt KGamePopupItem to Qt 4.5 and 4.6 improvements

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2296/
-----------------------------------------------------------

(Updated 2009-11-30 23:16:02.953922)


Review request for KDE Games and Dmitry Suzdalev.


Changes
-------

Describe what has changed in diff r2.


Summary (updated)
-------

Apart from some general cleanup, the most interesting changes are:
* Use QGraphicsItem::opacity. (KGamePopupItem::messageOpacity is deprecated now.)
* Use QGraphicsPathItem and QGraphicsPixmapItem instead of painting primitives.
* Improve event handling of the QGraphicsTextItem.
* Radically simplify internal layouting code.
* Instead of QTimeLine, animations are now implemented as QPropertyAnimations.
* Introduce methods to read and reset the appearance properties (messageIcon, textColor, backgroundBrush).
The last change introduces new public API. The patch includes an appropriate update to the unit test.

Note that the changes are rather extensive. (I estimate that 80% of the codebase has already changed, and I'm not finished yet.) If you prefer that, I can also send you 12 separate patches of the single commits I made in my git-svn repository.


Diffs
-----

  /trunk/KDE/kdegames/libkdegames/kgamepopupitem.h 1056063 
  /trunk/KDE/kdegames/libkdegames/kgamepopupitem.cpp 1056063 
  /trunk/KDE/kdegames/libkdegames/kgamepopupitem_p.h PRE-CREATION 
  /trunk/KDE/kdegames/libkdegames/tests/kgamepopupitemtest.h 1056063 
  /trunk/KDE/kdegames/libkdegames/tests/kgamepopupitemtest.cpp 1056063 
  /trunk/KDE/kdegames/libkdegames/tests/kgamepopupitemtest.ui 1056063 

Diff: http://reviewboard.kde.org/r/2296/diff


Testing (updated)
-------

I have used kgamepopupitemtest and did not find any regressions yet.


Thanks,

Stefan