[Kde-games-devel] Review Request: Adapt KGamePopupItem to Qt 4.5 and 4.6 improvements

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2296/
-----------------------------------------------------------

(Updated 2009-11-30 23:12:53.782651)


Review request for KDE Games and Dmitry Suzdalev.


Summary
-------

Apart from some general cleanup, the most interesting changes are:
* Use QGraphicsItem::opacity. (KGamePopupItem::messageOpacity is deprecated now.)
* Use QGraphicsPathItem and QGraphicsPixmapItem instead of painting primitives.
* Improve event handling of the QGraphicsTextItem.
* Radically simplify internal layouting code.
* Instead of QTimeLine, animations are now implemented as QPropertyAnimations and orchestrated by a QStateMachine.

Note that the changes are rather extensive. (I estimate that 80% of the codebase has already changed, and I'm not finished yet.) If you prefer that, I can also send you 12 separate patches of the single commits I made in my git-svn repository.


Diffs (updated)
-----

  /trunk/KDE/kdegames/libkdegames/kgamepopupitem.h 1056063 
  /trunk/KDE/kdegames/libkdegames/kgamepopupitem.cpp 1056063 
  /trunk/KDE/kdegames/libkdegames/kgamepopupitem_p.h PRE-CREATION 
  /trunk/KDE/kdegames/libkdegames/tests/kgamepopupitemtest.h 1056063 
  /trunk/KDE/kdegames/libkdegames/tests/kgamepopupitemtest.cpp 1056063 
  /trunk/KDE/kdegames/libkdegames/tests/kgamepopupitemtest.ui 1056063 

Diff: http://reviewboard.kde.org/r/2296/diff


Testing
-------

I have used kgamepopupitemtest to keep regressions at a minimum. I'm aware of and investigating the issue that hiding is not animated.


Thanks,

Stefan