[Kde-games-devel] Revised pixmap to svg script

[Parker Coates]

On Wed, Apr 15, 2009 at 1:16 PM, Parker Coates wrote:
> On Sat, Apr 11, 2009 at 7:21 AM, Luciano Montanaro wrote:
>> On martedì 07 aprile 2009, Parker Coates wrote:
>>> On Wed, Apr 1, 2009 at 11:21 AM, Parker Coates wrote:
>>> > On Mon, Mar 30, 2009 at 12:46 PM, Luciano Montanaro wrote:
>>> >> Oh, there was also the png-to-svn deck script, but that needs to run
>>> >> once only...
>>> >
>>> > Is there any reason we haven't proceeded with this? I think it'd be
>>> > great if we could remove support for PNG based decks in 4.3 as this
>>> > only clutters up an complicates the card selection dialog. I imagine
>>> > it would also allow us to remove a lot of code from KCardCache as
>>> > well. Personally, I don't think all of the PNG decks are really worth
>>> > converting to SVG, but I guess that's a separate topic.
>>>
>>> Because the soft feature freeze is today, I've added the conversion to
>>> only SVG carddecks to the 4.3 feature plan. I really think this is a
>>> worthwhile goal for 4.3.
>>>
>>
>> Oh, well. Let's do it for 4.3 then. I've far less free time than I'd like at
>> the moment, so I can't do much anyway. But this morning I fished out the old
>> script to see what else needed to be done and changed it a bit to make it
>> embed the pixmaps. It turned out to be easier than I thought.
>
> Thanks, Luciano. I too am short on time at the moment, but I think I
> should be able to at least get the decks converted before 4.3.
>
> There was a problem with the ordering of the card suits and ranks,
> which I've fixed in the attached version. Other than that, it seems to
> work quite well.

Okay, so I just committed the converted version of "Konqi Modern".
Please test, if possible.

This has, however, brought a new issue to light. If the user is
upgrading from a previous version, they will still have the original
PNG based decks installed, resulting in duplicates in the card dialog.
If we convert all the decks and then drop support for the old style
decks, then at least they'll be hidden from the dialog, but they'll
still be using up a few MB of disk space.

Is this something we're comfortable with? Is there any easy way to
clean up the files from an existing installation on upgrade?

Of course, after spending all this time in the carddecks directory,
I'm constantly questioning whether why we've even bothered holding on
to these old decks. We already ship a large selection of beautiful,
scalable decks. Why bother holding onto this cruft?

Parker