[Kde-games-devel] [PATCH] KGamePopupItem viewport handling

Sascha Peilicke sasch.pe at gmx.de
Thu Sep 11 14:23:17 CEST 2008


Hi,

KGamePopupItem is great for showing informational messages on a GraphicsScene. 
Unfortunatly it uses only the first viewport registered with a scene for it's 
position and size computation. This leads to unpleasant results when multiple 
views are used. 

KGo for example has  2 views displaying the scene one after another (one view 
for setup, one for gaming). The good thing is that they are not visible at 
the same time, so the attached patch makes KGamePopupItem render correctly in 
that case, it picks the first visible scene and uses that for computing it's 
position. This does not fix the main problem (no support for multiple views) 
but it should make KGamePopupItem work in the described situation.

I'd like to commit the patch in the next few days if nobody disagrees.
-- 
Kind regards,
Sascha Peilicke                                 http://www.saschashideout.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kgamepopupitem_viewport_fix.patch
Type: text/x-diff
Size: 974 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20080911/6037baa3/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20080911/6037baa3/attachment.sig 


More information about the kde-games-devel mailing list