[Kde-games-devel] KDiamond patch for checking board playability

[Paul B]

On Thursday 29 May 2008 21:12:44 Stefan Majewsky wrote:
> Despite from not having tested it, the patch looks very good.
> However, there are two points I would like to raise:
> 1. If at all, I would only include a full implementation, i.e.
> including the number of possible moves, and the hint button.
> (Perhaps also an undo button, but I'm not sure how the difficulty
> will be affected by this.)

Have patch now that shows the full amount of moves remaining in 
statusbar, and has hint button that selects the diamond needed to 
make combo, by setting m_selection1, m_selection1x and m_selection1y, 
then running m_selection1->show().

An undo button seems to me like it'd be unrelated to the features I've 
added in (whereas the moves remaining, hint button and checking if 
the game is playable were mostly done with the same function.)
I could of course work on it as well, but right now I'm not sure how 
I'd do it, I have a couple of ideas of ways to do it, but they all 
seem inefficient or overly-complicated for what doesn't seem that 
hard a task.

If you think that I'm doing this badly or think I could improve it 
please tell me, I'm doing this to practise my C++ and knowledge of 
KDE and Qt as well as trying to improve the game.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-diff
Size: 13065 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20080530/0c167252/attachment.bin