[Kde-games-devel] [PATCH] KSame: add info about points for marked stones

[Albert Astals Cid]

A Diumenge 30 Març 2008, Rafał Miłecki va escriure:
> 2008/3/26, Albert Astals Cid <aacid at kde.org>:
> > A Dimecres 12 Març 2008, Rafał Miłecki va escriure:
> > > When playing KSame I missed info saying how many points will I get for
> > >
> >  > removing marked stones. I added this to status bar just next to amount
> >  > of marked points.
> >  >
> >  > If you consied this usefully, I'll be glad to see this patch applied.
> >  >
> >  > There isn't any report on bugzilla about this.
> >  >
> >  > If something is worng with patch, please let me know. That's my first
> >  > KDE fix :)
> >
> > Did you get any answer to that?
>
> No. You are the only person who answered in this topic. I didn't get
> any other mails.

Ok, i hate when this happens, so let's just pretend i'm the game mantainer :-)

I have a problem with your patch, the thing is that now there are two places 
where score is calculated, board.cpp:254 and mainwindow.cpp:195 and that in 
my opinion is a bad idea, because if in the future someone decides to change 
how score is calculated it is easy that it will be forgotten to change in one 
of the places.

So could you please do this?

Create a static function on board that calculates the score given the stones 
and use it both in board.cpp:254 and mainwindow.cpp:195

Also i like more the "Marked: %1 (%2 Points)" than the "Marked: %1 
(Points: %2)" construct, what do you think?

Albert