[Kde-games-devel] KChat - is anyone using it?

[Alexander Smirnov]

Albert Astals Cid пишет:
>> I'm frighten by Hard Freeze. Actually i do not know where and what i am
>> allowed to submit and where and what i am not.
>>     
>
> KChatBase has a KChatBase::setModel so it seems to me a better idea adding 
> KChatBase::setDelegate than a new constructor in KChat.
>
> When doing that also fix KChatBase::setModel as it doesn't seem to do what it 
> should.
>   
yes, agree. Setting delegate should be possible too. I just wonder - why 
do you think that adding setters is better than adding one more 
constructor to derived class (KChat). I think that adding constructor is 
more effective because current constructor creates both default model 
and delegate. Setting them later via setSomething would be more time and 
memory consuming solution. And in light of that idea that delegate and 
view model in most cases are constant values and are not supposed to be 
changed during chat lifetime i think it's more reasonable to add 
constructor to init these values. ok, i could be wrong, please correct 
me if so. I'm new to KDE development.
>   
>> I tried to find docs on techbase regarding this policy but didn't found
>> :-|.
>>     
>
> http://techbase.kde.org/Schedules/KDE4/4.1_Release_Schedule
>
> May 19th, 2008: Hard Feature Freeze 
> Trunk is frozen for all feature commits, even those listed in the planned 
> feature document. Only bug fixes are allowed. Binary compatibility for new 
> API is not yet required. 
> 	
> Your fix is not a bugfix from my point of view.
>   
yes, it is not.
>   
>> What do you think - is this ok if i add this code now to
>> KDE/kdegames/libkdegames/kchat.(h,cpp) or not?
>>     
>
> No, it is not. You will have to wait until KDE 4.1 is released.
>   
no problem i will wait a bit. Just have a habit to submit small pieces 
of code :-)

Albert, I'd like to thank you one more time for explanation and hints 
you give to me. I really appreciate you help!

-Alexander