[Kde-games-devel] Patch to KGameThemeSelector

[Parker Coates]

Hello all,

Attached is a small patch to KGameThemeSelector that does three things.


1. It sorts the items in the list widget. I was having issues with
some themes showing up out of alphabetical order.

2. It converts the author email address to a clickable mailto link.
Previously it was just displayed as plain text.

3. It attempts to improve the resize behaviour of the widget.

    a) The widget had a maximum size set to 800x600. Restricting the
dialog size for those living with lower resolutions, but I don't think
this is the best way to to go about it. Applying a max size to the
configuration page doesn't stop the dialog itself from exceeding that
size, it just prevents the page from filling the dialog above that
size, which doesn't look very good. The maximum size should be applied
to the configuration dialog, which also takes into account the
dialog's titlebar, buttons, header, etc.

    b) The "Theme Details" section wouldn't line wrap. This caused a
long theme description to widen the dialog in an awkward way. All
three detail fields now word wrap with necessary and the layout has
been modified to ensure that everything still lines up.

    c) The preview image is now centred within its group box. This
makes things look nice when the group box is bigger than the preview.
When the group box is smaller than the preview, the centre of the
preview remains visible and the edges are cropped away. Presumably the
interesting bits of the preview are in the middle, so this should work
out well.

    d) There are also some other minor adjustments to size policies
and spacer placements to improve the resize behaviour of the dialog.
But of course, aesthetic improvements are largely subject to personal
taste and preference. So please try it out and reply if you think any
of the changes were detrimental.


I don't (yet) have an SVN account, so I'd be most appreciative if
someone would look over the patch and submit it.

Thanks,

Parker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kgamethemeselector.diff
Type: text/x-diff
Size: 12049 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20080228/eb02d46c/attachment.bin