[Kde-games-devel] Krazy Issues

Parker Coates parker.coates at gmail.com
Mon Dec 8 19:55:09 CET 2008


On Mon, Dec 8, 2008 at 13:32, Frederik Schwarzer wrote:
> On Monday 08 December 2008 18:47:29 Matthew Woehlke wrote:
>
> Hi,
>
>> Also, in kgame/dialogs/kgamedialogconfig.cpp, why only replace QLineEdit
>> with KLineEdit? Maybe it would be better to do as the TODO suggests and
>> use KIntNumInput instead?
>
> Unfortunately this dialog is not used at the moment so I cannot check it.
> However, does not look harmful, does it?

No, it doesn't look harmful, but the old behaviour wasn't technically
broken either. I would say that if the change can't be tested, because
the dialog is unused it's safer to leave it as is.

I guess the real question is why we have a class in libkdegames that
no one is using.

Parker


More information about the kde-games-devel mailing list