[Kde-games-devel] Krazy Issues

[Dmitry Suzdalev]

On Sunday 07 December 2008 14:42:03 Frederik Schwarzer wrote:
> While looking at some of the issues in libkdegames (for learning
> reasons), I created the attached patch. Does somebody want to
> have a look at it?

Looks nice to me, except that this change:

-	foreach(KGameDifficulty::standardLevel level, m_standardLevels) {
+	foreach(const KGameDifficulty::standardLevel &level, m_standardLevels) {

It's not really an optimization, because standardLevel is a enum, and passing 
it as a const reference doesn't bring any improvement - it'll be optimized by 
compiler.

Well, no harm either.

Cheers,
Dmitry.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20081207/fc51351c/attachment.htm