[Kde-games-devel] Fix for toggle actions in various games

Andreas Pakulat apaku at gmx.de
Wed Oct 31 22:09:38 CET 2007


On Sonntag, 28. Oktober 2007, Andreas Pakulat wrote:
> Hi,
>
> the games kolf, kpat and kbackgammon partly set different strings for
> the checked/unchecked states of a KToggleAction. IMHO this is
> extremely irritating when you read something like
>
> [X] Disable Autodrop
>
> Its also been discussed as part of this thread on the usability list:
> http://lists.kde.org/?t=117664078300013&r=1&w=2
>
> And as far as I can see the consensus is to either have a checkbox to
> indicate the state and have the same label for checked/unchecked
> state or have no checkbox and in that case have differing labels
> depending on the state.
>
> The attached patch removes all setCheckedState calls which makes all
> these entries have a checkbox and the same label for
> checked/unchecked state.
>
> Are there any objections against comitting this?

Comitted.

Andreas

-- 
Afternoon very favorable for romance.  Try a single person for a change.


More information about the kde-games-devel mailing list