[Kde-games-devel] Fix for toggle actions in various games

[mezz]

Hi,

I'd noticed the stupidity of this in Kolf a while ago, but in a quick look 
around the games couldn't see a clear consensus on how this sort of thing is 
handled so put sorting it out on my to do list and soon forgot about it. 

Your changes look perfect to me, I'd be very happy for you to commit

Paul
Kolf Maintainer

On Sunday 28 October 2007 15:39:29 Andreas Pakulat wrote:
> Hi,
>
> the games kolf, kpat and kbackgammon partly set different strings for
> the checked/unchecked states of a KToggleAction. IMHO this is extremely
> irritating when you read something like
>
> [X] Disable Autodrop
>
> Its also been discussed as part of this thread on the usability list:
> http://lists.kde.org/?t=117664078300013&r=1&w=2
>
> And as far as I can see the consensus is to either have a checkbox to
> indicate the state and have the same label for checked/unchecked state
> or have no checkbox and in that case have differing labels depending on
> the state.
>
> The attached patch removes all setCheckedState calls which makes all
> these entries have a checkbox and the same label for checked/unchecked
> state.
>
> Are there any objections against comitting this?
>
> Andreas