[Kde-games-devel] what to do about Bovo?

[Guillaume Denry]

2007/5/29, Guillaume Denry <guillaume.denry at gmail.com>:
>
>
>
> 2007/5/29, Johann Ollivier Lapeyre <johann.ollivierlapeyre at gmail.com>:
> >
> > Hi,
> >
> > Bovo was very good in playground, and after the dev approval, it was
> > moved to kdereview, even if the dev had a tmp computer issue.
> >
> > But now, the 1st june limit is coming, the aron's computer is still dead
> > for few days, and the kdereview's bovo is crashing since at least 1 week. I
> > asked to Guid to look on it, but he didn't found yet.
>
>
> Crash finally found. \o/
> I'll send the patch in a few minutes for a review, stay tuned.
>

Crash was caused by a multi-referencing of the same Coord pointer (m_coord)
in the Move class. (Because of the implicit copy constructor of Move which
copied pointers in the back() or last() function of QList)
I replaced "Coord *m_coord;" by "Coord m_coord;" and changed some Move
functions consequently, I think it won't cause any troubles now.

Guid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20070529/5afac6c1/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bovo.diff.gz
Type: application/x-gzip
Size: 573 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20070529/5afac6c1/attachment.gz