[Kde-games-devel] KsirK ready for kdegames ?

[Albert Astals Cid]

A Diumenge 14 Gener 2007 22:39, Kleag va escriure:
> Hello,
>
> The last step of porting KsirK to KDE4 is now finished. It is probably
> ready for inclusion in kdegames, if the following are the exact conditions:
> - working game : OK
> - with minimum doc : OK (full but to be updated and proof read)
> - all i18n : OK (already a few translations done)
> - KDE3/QT3 API free : OK (except a dependency in libkdegames)
> - GraphicsView framework : OK
> - SVG graphics : OK (well, there is still a lot of work for johann_ol or
> others :-) but the code is there !) except for icons
> - API documentation : YES, but to be completed and updated
>
> - GUI conformance to KDE rules:
>   * KsirK is toolbars only (no menu). Well, this is a game with its own
>     personality. This is what makes it different from other Risk games and
> from other KDE games, between other things. But I agree that access to help
> and manual should be better.
>   * Citing
> http://maupiacentini.blogspot.com/2006/11/first-kdegames-monthly-irc-meetin
>g.html: "There was discussion on the issue of using custom widgets for
> games. The general consensus was that we do not want to create a new widget
> set just for games, and will generally use what KDE offers in terms of
> dialog boxes, toolbars and other widgets."
>   Again, the special KsirK icons for "New Game", etc. make its identity. I
> suppose the general rule can be locally ignored if there is good reasons ?
>
> There is still some things to solve
> - Network games do not start very well
> - flag in player setup dialog is wrongly displayed
>
> There is also probably a few bugs but there is a long time before the
> release of KDE4 and so they will be corrected at this time.
>
> What do you think about the inclusion of KsirK now ?

Some thoughts:

 * The timer to get mouse position has to go away, if you want to know mouse 
position activate mouseTracking on the widget and use mousemoveevent.

 * I think using the status bar for questions and the toolbar for actions does 
not really work, because the question like "With how many armies do you 
defend Pakistan" is on the bottom part of the screen while the actions are on 
the top part. I'd go for a qwidget containing both a qlabel and some 
qpushbuttons.

 * What is the use of the button on the right part of the status bar? If it's 
only to show the current player make it a qlabel?

 * I find the current Drag and Drop mode for moving/attacking quite unnatural, 
i think a click to select origin + click to select destination is more 
natural. You are free to disagree of course ;.) But i'd want more comments 
from other people here.

 * A pause button is needed for the turn of the computer players.

 * About button crashes

 * Preferences button placement is strange, about should be probably the last, 
not preferences

 * There seems to be a maximum number of moves i can do per turn, but i can't 
find any place to see how much moves i have left.

 * Moving flags rock! :-)

 * If the map does not fit in the window i get no scrollbars

 * Dialogs need proper layouting.

You said in IRC that you need help for some things like layouting and 
graphics, i can help with layouting and sure others can help with graphics, 
but we need that on KDE svn. So at least i would approve a move to playground 
or kdereview as a first step, not sure about directly to kdegames itself.

Comments from others?

By the way, how does the "map" work? Is it SVG? If so how are the "countries" 
detected?

Albert

>
> Regards,
>
> Kleag
>
> P.S.: if you want to try the KDE4 version of KsirK, download the SVN trunk
> here: "svn co svn://svn.gna.org/svn/ksirk/trunk ksirk"