[Kde-games-devel] KDE/kdebase/workspace/ksysguard/gui/SensorDisplayLib

[Dmitry Suzdalev]

On Monday 10 December 2007 09:18:35 Greg Martyn wrote:
> SVN commit 746778 by martyn:
>
> BUG: 153512
>
> It appears this code was a performance optimization that relied on a bug in
> qt that has since been fixed. see
> http://archives.devshed.com/forums/kde-96/saving-overheads-when-resizing-sv
>g-2318239.html
>
> It didn't save much computation anyway -- all we do is change the value of
> one variable.
>
> The code I'm removing waited for the second of two resize events. We no
> longer get two resize events, so we ended up completely ignoring the resize
> event.
Are you sure about this? If this is the case we should do the same in kdegames - we have some games relying on these "two resize events"

Cheers,
Dmitry.

>
>
>  M  +0 -4      SignalPlotter.cc
>
>
> ---
> trunk/KDE/kdebase/workspace/ksysguard/gui/SensorDisplayLib/SignalPlotter.cc
> #746777:746778 @@ -439,10 +439,6 @@
>  void KSignalPlotter::resizeEvent( QResizeEvent* )
>  {
>    Q_ASSERT( width() > 2 );
> -//  mBackgroundImage = mBackgroundImage.scaled(width(), height()); //set
> to null.  If it's invalid, it will be rerendered. -  if
> (testAttribute(Qt::WA_PendingResizeEvent)) {
> -      return; // we'll be back here again in no time
> -  }
>
>    updateDataBuffers();
>  }

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20071210/bb3fa6bc/attachment.html