[Kde-games-devel] KDE4 and QGraphicsView port of KGoldrunner

[Dmitry Suzdalev]

On Thursday 10 August 2006 01:17, Mauricio Piacentini wrote:
> > It's issued because these actions aren't added to KMainWindow.
> > You'll need to call addAction(act) on corresponding KActions in
> > KGoldRunner::setupActions().
>
> Yes, that solved it. It is strange that this was not apparently required
> in KDE3, as the game was previously working without addAction(). I added
> these and keyboard play is now operational, thanks!
If i understood correctly in KDE3 this adding of actions happened 
automatically...

> > So what stops you from commiting? ;)
> > I guess you can do it in one go, no need to split.
>
> I usually prefer to commit each change separately so we can see when
> something is broken. But in this case this is not really possible, since
> the port is more or less a job that spawns several interrelated files.
> Commit is done, already with this fix and some minor ones as well. Still
> lots of layout issues to sort, but we are getting there. Only bug is
> saving, I comment it in the patch and will investigate it.
Congratulations on your first commit(s)! :-)

Dmitry.