[Kde-games-devel] KGame: A few questions

[Albert Astals Cid]

A Diumenge 01 Agost 2004 21:28, Inge Wallin va escriure:
> On Sun, 1 Aug 2004, Martin Heni wrote:
>
> I couldn't find anything more official than this link to KDE myths
> (http://kdemyths.urbanlizard.com/viewMyth.php?mythID=42).  Did you have
> anything else in mind?

Have a look at 
http://developer.kde.org/documentation/library/kdeqt/kde3arch/devel-binarycompatibility.html

>
> Anyway, as I mentioned above, I don't think we need to actually change
> KGame et al.  We only need to introduce some inheritances and
> specializations.
>
>
> So, without further ado, here is my current work plan:
>
> I. Prepare kreversi for use of KGame.  This consists mainly of some small
>    refactorizations.
>    a. Change the name Player in Score.h to Color.  This is actually what
>       it is.
>    b. Introduce "Color  m_to_move" into the class Position.  The color to
>       move is definitely part of the position of a game.
>    c. Maybe remove the class Score, since it is mainly a trivial array[2]
>       of ints.
>
>    These steps should be fairly uncontroversial.
>
>    d. Separate the engine into its own subdirectory.  This would prepare
>       for the possibility of more (and better!) engines as well as
>       separating the code for the view (actual GUI) from the document (the
>       Game).
>
>    Somewhat controversial since CVS is so bad at things like this.
>
> II. Switch kreversi over to using KGame et al.
>    I think that this has to be done in one step.  I don't think we can
>    do this in smaller increments.  I will try to make the code changes as
>    small as possible though.
>
> III. Enhance kreversi with new functions made possible by KGame.  Many of
>      these are taken from bugzilla.
>    a. Human-human game
>    b. Computer-computer game
>    c. Network game

:) :) :) :) :) :) :) :) :) 

>
> In parallel with these enhancements, I would like to enhance the code
> quality.  For one thing, there are too few comments to my liking.  For
> another, the lack of formatting in many places obscures the inner working
> unnecessarily.

Comments are generally somewhat missing in all KDE :-(

>
> Until I have my own CVS privileges, I will send the patches to the list
> for comments.  Then somebody has to commit the changes.  I had some
> contact with Nicolas Hadacek earlier this summer and he seemed to be
> somewhat in charge of kreversi.  Maybe he or You (Martin) would be the
> best to do it?

If you plan to do that kind of heavy work on kreversi i'll suggest asking for 
CVS access as it will be easier for you.

>
> So.  Now to some practical questions.  I understand that there is a code
> freeze in place, and that there will be so until KDE 3.3 is released.
>
> 1. Comments on the plan?

Seems good :)

>
> 2. Can I / we perhaps work on a CVS branch until the end of the freeze?  I
>    have seen other examples of this

You can do it, but you can also work localy on your machine and wait until the 
freeze ends, have a look at 
http://developer.kde.org/development-versions/kde-3.3-release-plan.html for 
an estimate of the freeze ending
    . 
>
> 3. Shall I send the patches to the list or in private mail?

As i said i think it will be better for you to ask for a CVS account.

Albert