[Kde-games-devel] Patch for KBattleShip

[Albert 'TSDgeos' Astals Cid]

The patch removes the need for these files

kbattleship/ksingledialog.cpp
kbattleship/ksingledialog.h
kbattleship/dialogs/singleDlg.ui

as the dialog created with this files can be obtained using 
KLineEditDlg::getText and i think is better to use that than 2 more classes.

Also changes some 
QTimer::singleShot(0, this, SLOT(slotDeleteClient()));
to 
slotDeleteClient();
as i think the effect is the same and we don't need a timer for that.

And finally change 
if(m_aiPlaying) m_aiPlayer->slotRequestShot();
of position and get it lower in the code as in the position it was, it was 
calling the AI player movement before checking if the player was winning with 
that movement.

Also some functions (now that i've removed the QTimer thing) don't need to be 
slots, i haven't renamed them nor changed them from private slots to private 
in the .h

Should i?

If the patch is merged, i suppose the non needed files should be removed from 
makefile.am or something like that, but i hace touched that as i am not very 
familiar with automake/autoconf files

The patch comes attached

Comments are welcome :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MY_DIFF
Type: text/x-diff
Size: 4501 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-games-devel/attachments/20030528/7bcbc7d3/MY_DIFF.bin