Why is video capture patched out?

[Tobias C. Berner]

Moin moin

Kai recently provided patches to enable it again in Qt5.14 which will land
in the tree soonish.


https://github.com/freebsd/freebsd-ports-kde/commit/28d0600bd27b3c39d678f3106da9dff0d82a41c6

Mfg Tobias

Tamas Szakaly <sghctoma at gmail.com> schrieb am Do., 9. Apr. 2020, 12:57:

> Dear kde@ and chromium@ team!
>
> Due to the situation the world is in right now, I needed WebRTC-based
> video conferencing to work, so I was poking around in the www/qt5-webengine
> code. What I've found is that video capture is patched out with the
> following two files:
>
>  -
> patch-src_3rdparty_chromium_media_capture_video_linux_video__capture__device__factory__linux.cc
>  -
> patch-src_3rdparty_chromium_media_capture_video_linux_video__capture__device__linux.cc
>
> With these patches applied,
> VideoCaptureDeviceFactoryLinux::HasUsableFormats always returns false, so
> capable devices are not even detected. When I remove those "#if
> !defined(OS_FREEBSD)" lines, video capture works fine; I've been using
> Jitsi and Facebook Messenger for a few days now from qutebrowser. I haven't
> tried them yet, but www/chromium and www/iridium has these patches too. I
> should also say that I've made a comment with essentially the same content
> on a Bugzilla issue (
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245250), so apologies
> if this mail is redundant.
>
> What I'd like to ask is if there's any reason for these patches (maybe
> some known problems that do not occur on my box), or they are just leftover
> files from earlier versions. I've tried searching for some info on this,
> tried git --follow, but couldn't find anything.
>
> Best regards,
> Tamas
>
> --
> Tamas Szakaly
> @sghctoma
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-freebsd/attachments/20200409/2a06ae0c/attachment.html>