Why is video capture patched out?

Tamas Szakaly sghctoma at gmail.com
Tue Apr 7 05:49:04 BST 2020


Dear kde@ and chromium@ team!

Due to the situation the world is in right now, I needed WebRTC-based video conferencing to work, so I was poking around in the www/qt5-webengine code. What I've found is that video capture is patched out with the following two files:

 - patch-src_3rdparty_chromium_media_capture_video_linux_video__capture__device__factory__linux.cc
 - patch-src_3rdparty_chromium_media_capture_video_linux_video__capture__device__linux.cc

With these patches applied, VideoCaptureDeviceFactoryLinux::HasUsableFormats always returns false, so capable devices are not even detected. When I remove those "#if !defined(OS_FREEBSD)" lines, video capture works fine; I've been using Jitsi and Facebook Messenger for a few days now from qutebrowser. I haven't tried them yet, but www/chromium and www/iridium has these patches too. I should also say that I've made a comment with essentially the same content on a Bugzilla issue (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245250), so apologies if this mail is redundant.

What I'd like to ask is if there's any reason for these patches (maybe some known problems that do not occur on my box), or they are just leftover files from earlier versions. I've tried searching for some info on this, tried git --follow, but couldn't find anything.

Best regards,
Tamas

-- 
Tamas Szakaly
@sghctoma



More information about the kde-freebsd mailing list