[kde-freebsd] cad/qcad patch (was Re: [Bug 202808] [exp-run] Update Qt 4 ports to 4.8.7)

[Raphael Kubo da Costa]

(Changing subject to stop mixing this with the Bugzilla thread)

Ralf Nolden <nolden at kde.org> writes:
> https://share.kde.org/index.php/s/edezR7j3uc91g0N
>
> against head svn-diff-r386828-qcad-3.10.0.0-qt550.diff
>
> patch for 3.10.0.0 compiled and tested with qt-5.5.0 using the quazip-qt5
> patch posted earlier. I've both versions of libquazip installed this way at
> the same time, ldd shows the right one is picked up.
>
> ldd /usr/local/lib/libqcadzip.so
> /usr/local/lib/libqcadzip.so:
>         libqcadcore.so => /usr/local/lib/libqcadcore.so (0x801800000)
>         libquazip.so => /usr/local/lib/qt5/libquazip.so (0x80220b000)
>
> Hope this helps keeping qcad in ports for the foreseeable future :)

Thanks for the patch. I've taken a look at it, and tried it out, and it
needs some improvements:
- It's actually missing dependencies. I'm not sure if you tried building
  the port inside Poudriere, but it fails at the configuration stage if
  you don't depend on uitools and concurrent.
- `make check-plist' is broken:
  ===> Checking for items in pkg-plist which are not in STAGEDIR
  Error: Missing: %%DATADIR%%/plugins/script/%%QT_LIBDIR%%qtscript_network.so.1.0.0
- files/patch-support_ecmagenerator_src_srcml_RSpline.srcml needs to be
  updated, not removed. The lines that it used to change were just moved
  around.
- Just like the patches in the port make it use openNURBS from the tree
  instead of the bundled copy, it would probably make sense to do the
  same with quazip. Bundled libraries are evil.
- Remember that at the end you'll need to submit a PR for the port's
  maintainer to approve :-)