[kde-freebsd] [SVN Commit] area51/PORTS/devel/qtcreator

[Alberto Villa]

On Mon, Sep 3, 2012 at 12:22 PM, Raphael Kubo da Costa
<rakuco at freebsd.org> wrote:
> Changing DIST_SUBDIR will probably force people to download the tarball
> again and the old copy will stay around indefinitely, but I don't know
> if this can be fixed.

This happens on every update of every port, so it's not a problem. The
distfile will be removed if the user runs a cleanup utility.

> As for DIST_NO_EXTRACT, isn't it possible to be more aggressive? Only
> src/ and include/ seem to be used from the Qt tarball.

I used the same logic i developed when I did it (re-did it, actually,
as the first iteration belongs to makc@ as far as I know) in Qt: avoid
extracting anything bigger than 1 MB. It could be more aggressive
removing also some src/* directory, but it's not worth it in my
opinion (I plan to revisit this stuff when I start working on Qt 5,
doing some benchmark maybe).

> One last thing: was the change to DESKTOP_ENTRIES needed?

I don't think so, I was just trying to be consistent with other Qt
ports. It probably misses a "%F" too, but I'd like to sudy a bit more
before changing this and the other Qt ports consistently.
-- 
Alberto Villa, FreeBSD committer <avilla at FreeBSD.org>
http://people.FreeBSD.org/~avilla