[kde-freebsd] Re: [SVN Commit] area51/PORTS/Mk

[Dima Panov]

Hello!

08.04.2011, 21:16, "Alberto Villa" <avilla at freebsd.org>:
> On Friday 08 April 2011 12:10:06 Max Brazhnikov wrote:
>
>>  SVN commit 7127 by makc:
>>
>>  Set CMAKE_BUILD_TYPE to Release by default and to Debug if
>
> WITH_DEBUG is
>
>>  defined. Pass CMAKE_BUILD_TYPE to PLIST_SUB
>
> this will hardcode -O3 in CFLAGS. are we sure we want it? perhaps there
> is an easy way to void them
> by the way, this requires an exp-run (with both "release" and "debug")
> and some plist fixes, but i think you already know

If -O3 will cause instablity, we can simply patch cmake itself to use -O2 :) 

In share/cmake/Modules/Compiler/GNU.cmake, IIRC

>
>>  Empty CMAKE_BUILD_TYPE or far-fetched like FreeBSD_portbld makes
>
> no sense
>
>>  and/or causes problems sometimes.
>
> yep
>
> --
> Alberto Villa, FreeBSD committer <avilla at FreeBSD.org>;
> http://people.FreeBSD.org/~avilla
>
> Money is the root of all wealth.
>
> _______________________________________________
> kde-freebsd mailing list
> kde-freebsd at kde.org
> https://mail.kde.org/mailman/listinfo/kde-freebsd
> See also http://freebsd.kde.org/ for latest information

-- 
Dima Panov (fluffy at FreeBSD.org)
KDE at FreeBSD team

Facebook: http://www.facebook.com/?id=100000181104157