[kde-freebsd] ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices

[Emil Smolenski]

The following reply was made to PR ports/133078; it has been noted by GNATS.

From: "Emil Smolenski" <am at raisa.eu.org>
To: miwi at freebsd.org
Cc: bug-followup at freebsd.org, kde at freebsd.org
Subject: Re: ports/133078: [PATCH] kmix (multimedia/kdemultimedia4)
 incorrectly binds to mixer devices
Date: Sat, 13 Feb 2010 22:51:14 +0100

 On Sat, 13 Feb 2010 17:12:41 +0100, <miwi at freebsd.org> wrote:
 
 > Synopsis: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to  
 > mixer devices
 >
 > State-Changed-From-To: open->closed
 > State-Changed-By: miwi
 > State-Changed-When: Sat Feb 13 16:12:40 UTC 2010
 > State-Changed-Why:
 
 > should be fixed long time ago.
 
   No. Unfortunately it is still broken. This code from "kmix/mixer_oss.cpp"  
 file hasn't changed:
 
    switch (devnum) {
    case 0:
      return QString("/dev/mixer");
      break;
 
    default:
      QString devname("/dev/mixer");
      devname += ('0'+devnum);
      return devname;
 
 
 % pkg_info -xI kdem
 kdemultimedia-4.3.5 KDE Multimedia applications
 
 % lsof -c kmix -a /dev/mixer /dev/mixer*
 COMMAND   PID  USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
 kmix    21289 ameel   10u  VCHR   0,34      0t0   34 /dev/mixer1
 kmix    21289 ameel   12u  VCHR   0,34      0t0   34 /dev/mixer1
                                                       ^^^^^^^^^^^
 
 Kmix still binds to the same mixer twice. There is no possibility to  
 control mixer0 from kmix when hw.snd.default_unit is set to 1. The switch  
 construction above is obviously wrong.
 
 Also, all mixer devices have still the same name (meaningless "OSS Audio  
 Mixer"). My patch still applies (with small offset).
 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=133078
 
 
 -- 
 am