Patch for exception.h

Friedrich W. H. Kossebau kossebau at kde.org
Thu Mar 25 06:59:27 GMT 2021


Am Donnerstag, 25. März 2021, 06:59:35 CET schrieb Christian Riggenbach:
> >Interesting that you are the first one to hit this in all the years...
> >but I
> >agree with your fix, is consistent with the other export header
> >includes and
> >needed, both for the CamelCase forward includes but also the normal
> >direct
> >include <hreadweaver/exception.h> as well.
> 
> Yeah, it surprised me as well.
> 
> The underlying problem was, that reimplementing Job::success() didn't work.
> It wasn't called at any time (checked with a simple std::cout << "";), so
> failing a job was only possible by throwing Threadweaver::JobFailed(). I
> didn't dig deeper in the source than job.cpp, where throwing an exception
> is catched by the executor, which sets the state accordingly.
> 
> Is it a bug or just not documented corrected?

No proper insight into Threadweaver myself here. If no-one else picks up your 
question here on the ML in the next days I propose to file a bug then, hoping 
that someone with clue might have time one day to pick up this issue.

Cheers
Friedrich




More information about the Kde-frameworks-devel mailing list