D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

Pino Toscano noreply at phabricator.kde.org
Sat Sep 12 13:57:32 BST 2020


pino added a comment.


  In D29299#676439 <https://phabricator.kde.org/D29299#676439>, @dfaure wrote:
  
  > @pino Other than the fact that you think D29136 <https://phabricator.kde.org/D29136> is "good enough", do you have any concrete objection to this version?
  
  
  I think I already wrote enough comments on this...
  
  I asked for actual **valid** use cases when using the new variables first would break, and I still got none. There is a limit to how much you can keep broken code working... assuming such broken code exists. I don't think there is any of this such situation, as `ki18n_install()` is basically used by KF sources that use ECM already, with marble being the only exception (and even that, marble won't break).
  
  Oh, and just to make it clear: none of my comments implies that I don't care about ECM, nor about any users of it, nor that I "like" to purposefully break cmake scripts.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29299

To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano
Cc: dfaure, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200912/a8574902/attachment.htm>


More information about the Kde-frameworks-devel mailing list