D28745: Skip caching thumbnails on encrypted filesystems

[Stefan Brüns]

bruns added a comment.


  In D28745#676320 <https://phabricator.kde.org/D28745#676320>, @marcingu wrote:
  
  > In D28745#676317 <https://phabricator.kde.org/D28745#676317>, @bruns wrote:
  >
  > > In D28745#676313 <https://phabricator.kde.org/D28745#676313>, @marcingu wrote:
  > >
  > > > Ping!
  > > >  I'm remanding about question early, because I could do much more work if I get to do it on weekend.
  > > >
  > > > Question:
  > > >  This code won't save thumbnail for file on any device that isn't `StorageVolume` or is `StorageVolume` with `usage` `UsageType::Encrypded`.
  > >
  > >
  > > The whole block can never return true, so it should just be removed, along with all its dependencies.
  >
  >
  > I tested it once more and it returns true when it should, as expected. What makes you think it doesn't?
  
  
  Even worse, its almost random:
  
    udi = '/org/kde/fstab///pebbles/foo:/mnt'
      parent = '/org/kde/fstab'  (string)
      vendor = 'pebbles'  (string)
      product = 'foo:/mnt'  (string)
      description = 'foo:/mnt on pebbles'  (string)
      icon = 'network-server'  (string)
      StorageAccess.accessible = false  (bool)
      StorageAccess.filePath = '/mnt'  (string)
      StorageAccess.ignored = false  (bool)
      NetworkShare.type = 'Cifs'  (0x2)  (enum)
      NetworkShare.url = 'smb://pebbles/foo:/mnt'  (string)
  
  `if (device.is<Solid::StorageVolume>())` -> false, though it should be cached
  
    udi = '/org/freedesktop/UDisks2/block_devices/dm_2d2'
      parent = '/'  (string)
      vendor = ''  (string)
      product = ''  (string)
      description = '100,0 GiB Hard Drive'  (string)
      icon = 'drive-harddisk-root'  (string)
      Block.major = 254  (0xfe)  (int)
      Block.minor = 2  (0x2)  (int)
      Block.device = '/dev/dm-2'  (string)
      StorageAccess.accessible = true  (bool)
      StorageAccess.filePath = '/'  (string)
      StorageAccess.ignored = true  (bool)
      StorageVolume.ignored = false  (bool)
      StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
      StorageVolume.fsType = 'btrfs'  (string)
      StorageVolume.label = ''  (string)
      StorageVolume.uuid = '5832ebfa-bf02-40d2-bdc7-90403b207b62'  (string)
      StorageVolume.size = 107374182400  (0x1900000000)  (qulonglong)
  
  This is an LUKS encrypted volume so should be cached ...

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200904/f86f7baf/attachment-0001.htm>