<table><tr><td style="">bruns added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28745">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28745#676320" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28745#676320</a>, <a href="https://phabricator.kde.org/p/marcingu/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@marcingu</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28745#676317" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28745#676317</a>, <a href="https://phabricator.kde.org/p/bruns/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@bruns</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D28745#676313" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28745#676313</a>, <a href="https://phabricator.kde.org/p/marcingu/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@marcingu</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Ping!<br />
I'm remanding about question early, because I could do much more work if I get to do it on weekend.</p>
<p>Question:<br />
This code won't save thumbnail for file on any device that isn't <tt style="background: #ebebeb; font-size: 13px;">StorageVolume</tt> or is <tt style="background: #ebebeb; font-size: 13px;">StorageVolume</tt> with <tt style="background: #ebebeb; font-size: 13px;">usage</tt> <tt style="background: #ebebeb; font-size: 13px;">UsageType::Encrypded</tt>.</p></div>
</blockquote>
<p>The whole block can never return true, so it should just be removed, along with all its dependencies.</p></div>
</blockquote>
<p>I tested it once more and it returns true when it should, as expected. What makes you think it doesn't?</p></div>
</blockquote>
<p>Even worse, its almost random:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">udi = '/org/kde/fstab///pebbles/foo:/mnt'
parent = '/org/kde/fstab' (string)
vendor = 'pebbles' (string)
product = 'foo:/mnt' (string)
description = 'foo:/mnt on pebbles' (string)
icon = 'network-server' (string)
StorageAccess.accessible = false (bool)
StorageAccess.filePath = '/mnt' (string)
StorageAccess.ignored = false (bool)
NetworkShare.type = 'Cifs' (0x2) (enum)
NetworkShare.url = 'smb://pebbles/foo:/mnt' (string)</pre></div>
<p><tt style="background: #ebebeb; font-size: 13px;">if (device.is<Solid::StorageVolume>())</tt> -> false, though it should be cached</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">udi = '/org/freedesktop/UDisks2/block_devices/dm_2d2'
parent = '/' (string)
vendor = '' (string)
product = '' (string)
description = '100,0 GiB Hard Drive' (string)
icon = 'drive-harddisk-root' (string)
Block.major = 254 (0xfe) (int)
Block.minor = 2 (0x2) (int)
Block.device = '/dev/dm-2' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/' (string)
StorageAccess.ignored = true (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'btrfs' (string)
StorageVolume.label = '' (string)
StorageVolume.uuid = '5832ebfa-bf02-40d2-bdc7-90403b207b62' (string)
StorageVolume.size = 107374182400 (0x1900000000) (qulonglong)</pre></div>
<p>This is an LUKS encrypted volume so should be cached ...</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28745">https://phabricator.kde.org/D28745</a></div></div><br /><div><strong>To: </strong>marcingu, ivan, broulik, Dolphin, ngraham, meven, bruns, dfaure<br /><strong>Cc: </strong>dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov<br /></div>