D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

Kevin Ottens noreply at phabricator.kde.org
Mon May 25 09:17:10 BST 2020


ervin added inline comments.

INLINE COMMENTS

> meven wrote in device.h:99
> Well I have to make this virtual it seems so this call is dynamically dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), QString(), displayName());`
> I assumed this would work based on my review comments rather than on tests :/

Woops... my bad, indeed didn't notice it wasn't marked virtual anymore. It has to be indeed.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure, ngraham
Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200525/8b6ebc24/attachment.htm>


More information about the Kde-frameworks-devel mailing list