D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts
Méven Car
noreply at phabricator.kde.org
Mon May 25 07:47:27 BST 2020
meven added a comment.
The patch currently does not work.
INLINE COMMENTS
> ervin wrote in device.h:99
> Why not have a default implementation which returns descriptions()? This would make for a less intrusive patch (I think it's in part what @bruns suggested earlier).
Well I have to make this virtual it seems so this call is dynamically dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), QString(), displayName());`
I assumed this would work based on my review comments rather than on tests :/
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D28590
To: meven, #frameworks, bruns, sitter, dfaure, ngraham
Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200525/597ded38/attachment.htm>
More information about the Kde-frameworks-devel
mailing list