D19080: Make file overwrite a bit safer
David Faure
noreply at phabricator.kde.org
Fri May 8 12:58:25 BST 2020
dfaure added inline comments.
INLINE COMMENTS
> dfaure wrote in jobtest.cpp:1759
> The other problems were fixed, but this test still fails randomly.
>
> In fact, why are we checking that the dest file already started to be created when totalSize is emitted?
> Surely copying involves looking at the src file first, emitting totalSize, and *then* starting to create the destination, no?
>
> Maybe it's not totalSize we should connect to, but more of a progress signal....
Done in https://commits.kde.org/kio/30d74b814f794e52fa4561181b7b864558144e3a
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19080
To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200508/c8856558/attachment.htm>
More information about the Kde-frameworks-devel
mailing list