D19080: Make file overwrite a bit safer

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> jobtest.cpp:1759
> +        Q_UNUSED(totalSize);
> +        QCOMPARE(destFileExists,  QFile::exists(destPartFile));
> +    });

The other problems were fixed, but this test still fails randomly.

In fact, why are we checking that the dest file already started to be created when totalSize is emitted?
Surely copying involves looking at the src file first, emitting totalSize, and *then* starting to create the destination, no?

Maybe it's not totalSize we should connect to, but more of a progress signal....

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19080

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200508/e9a52959/attachment-0001.htm>