D28372: Added a merged look to the plasmoidheading and remove roundedborders

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> PlasmoidHeading.qml:58
> +     * If false, the plasmoidheading will display a separator. If true, it will be considered merged
> +     * with another plasmoidheading and the separator won't be showed.
> +     */

Worth writing "the default value is false" in the docs, as it's what most people look for.

> PlasmoidHeading.qml:77
>          imagePath: "widgets/plasmoidheading"
> -        prefix: location == PlasmoidHeading.Location.Header? 'header' : 'footer'
> -        enabledBorders: {
> -            var borders = new Array()
> -            borders |= PlasmaCore.FrameSvg.LeftBorder
> -            borders |= PlasmaCore.FrameSvg.RightBorder
> -            if (plasmoid.location !== PlasmaCore.Types.TopEdge || location != PlasmoidHeading.Location.Header) {
> -                borders |= PlasmaCore.FrameSvg.TopBorder
> -            }
> -            if (plasmoid.location !== PlasmaCore.Types.BottomEdge || location != PlasmoidHeading.Location.Footer) {
> -                borders |= PlasmaCore.FrameSvg.BottomBorder
> -            }
> -            return borders
> -        }
> +        prefix: (merged ? 'merged-' : '') + (location == PlasmoidHeading.Location.Header? 'header' : 'footer')
>      }

What should happen if this is set to merged and someone uses a theme that doesn't have a merged- prefix?

The old SVG or no SVG at all?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200328/8e68f27a/attachment.html>