<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28372">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28372#inline-161444">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PlasmoidHeading.qml:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     * If false, the plasmoidheading will display a separator. If true, it will be considered merged</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     * with another plasmoidheading and the separator won't be showed.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">     */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Worth writing "the default value is false" in the docs, as it's what most people look for.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28372#inline-161445">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PlasmoidHeading.qml:77</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">imagePath:</span> <span style="color: #766510">"widgets/plasmoidheading"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">prefix:</span> <span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmoidHeading</span><span class="p">.</span><span style="color: #004012">Location</span><span class="p">.</span><span style="color: #004012">Header</span><span style="color: #aa2211">?</span> <span style="color: #766510">'header'</span> <span style="color: #aa2211">:</span> <span style="color: #766510">'footer'</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">enabledBorders:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">var</span> <span style="color: #004012">borders</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #304a96">Array</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">LeftBorder</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">RightBorder</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">!==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">TopEdge</span> <span style="color: #aa2211">||</span> <span style="color: #004012">location</span> <span style="color: #aa2211">!=</span> <span style="color: #004012">PlasmoidHeading</span><span class="p">.</span><span style="color: #004012">Location</span><span class="p">.</span><span style="color: #004012">Header</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">TopBorder</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">plasmoid</span><span class="p">.</span><span style="color: #004012">location</span> <span style="color: #aa2211">!==</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">Types</span><span class="p">.</span><span style="color: #004012">BottomEdge</span> <span style="color: #aa2211">||</span> <span style="color: #004012">location</span> <span style="color: #aa2211">!=</span> <span style="color: #004012">PlasmoidHeading</span><span class="p">.</span><span style="color: #004012">Location</span><span class="p">.</span><span style="color: #004012">Footer</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #004012">borders</span> <span style="color: #aa2211">|=</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">FrameSvg</span><span class="p">.</span><span style="color: #004012">BottomBorder</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">return</span> <span style="color: #004012">borders</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">prefix:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">merged</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">'merged-'</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">''</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span style="color: #004012">location</span> <span style="color: #aa2211">==</span> <span style="color: #004012">PlasmoidHeading</span><span class="p">.</span><span style="color: #004012">Location</span><span class="p">.</span><span style="color: #004012">Header</span><span style="color: #aa2211">?</span> <span style="color: #766510">'header'</span> <span style="color: #aa2211">:</span> <span style="color: #766510">'footer'<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What should happen if this is set to merged and someone uses a theme that doesn't have a merged- prefix?</p>

<p style="padding: 0; margin: 8px;">The old SVG or no SVG at all?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28372">https://phabricator.kde.org/D28372</a></div></div><br /><div><strong>To: </strong>niccolove, Plasma<br /><strong>Cc: </strong>davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>