D28128: Add force save behavior to KEntryMap

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sounds like you need another feature, not breaking an existing one.

INLINE COMMENTS

> kconfigtest.cpp:1965
> +    QVERIFY(local.sync());
> +    QCOMPARE(generalLocal.readEntry("testRestore", 1), 20);
> +

This would pass no matter in which file the write happened, no, due to caching?
Doesn't this need a generalLocal.reparseConfiguration() to be meaningful?

> kconfigtest.cpp:1970
> +    local.reparseConfiguration();
> +    QCOMPARE(generalLocal.readEntry("testRestore", 1), 1);
> +}

Hmm, so this is what this is all about?

This contradicts the documentation for revertToDefault().

- Reverts the entry with key @p key in the current group in the
- application specific config file to either the system wide (default)
- value or the value specified in the global KDE config file.

The value in the global config file is 10, that's what this is supposed to revert to.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200323/4d487095/attachment.html>