D28122: Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78241.
ahmadsamir retitled this revision from "Move/port KFontDialog from KDELibs4Support to KWidgetAddons" to "Copy KFontDialog from KDELibs4Support to KWidgetAddons, now KFontChooserDialog".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a reviewer: dfaure.
ahmadsamir removed subscribers: dfaure, kossebau.
ahmadsamir added a comment.
This revision is now accepted and ready to land.


  Address comments:
  
  - Drop the fontList parameter in the ctor, it's not useful, 99% of the times users of this class call the static getFont() methods
  - Make the parent QWidget * the last param. in the ctor, a la Qt API
  - Change stripRegularStyleName() to be file-static
  - Add @since
  - Don't call setModal(true), exec() takes care of that
  - More const

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28122?vs=78153&id=78241

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

AFFECTED FILES
  docs/pics/kfontchooserdialog.png
  src/CMakeLists.txt
  src/kfontchooserdialog.cpp
  src/kfontchooserdialog.h
  tests/CMakeLists.txt
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns, dfaure, kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200322/6e3f8629/attachment-0001.html>