D28169: [DesktopExecParser] Let the service open protocols is claims to support

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> desktopexecparser.cpp:350
>              const QUrl url = d->urls.at(i);
> -            if (hasSchemeHandler(url)) {
> +             // if the app/service claims to support opening this protocol, let it
> +            if (isProtocolInSupportedList(url, appSupportedProtocols)) {

Doesn't this break the special case in the comment below?
VLC claims to support smb:// but if we have a password, we need to be able to pass it, so we want to use KIOFuse?

And then if you fix that, we're back to a simple revert of the last commit, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200320/d723fcf1/attachment.html>