D28169: [DesktopExecParser] Let the service open protocols is claims to support

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, sitter, feverfew, ngraham.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This reverts commit 14b7f2c7ee72b <https://phabricator.kde.org/R241:14b7f2c7ee72bbf500625122a4b51c81f02e421f>; the added unit test failed on the
  CI system because hasSchemeHandler() couldn't find the ktelnetservice5.desktop
  file in /usr/share/applications, as KIO isn't installed on the CI system.
  
  However, if we have a service and it claims to support opening urls with
  certain protocols/schemes, then we should let it do that.
  
  Besides the original condition seems flawed as it meant that even if
  isProtocolInSupportedList() returned true, we'd still take the
  KIOFuse path.
  
  CCBUG: 418258

TEST PLAN
  kiowidgets-krununittest passes

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28169

AFFECTED FILES
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200320/43f88c03/attachment.html>