D26858: Provide an implementation for the tablet interface
David Edmundson
noreply at phabricator.kde.org
Wed Mar 18 16:04:01 GMT 2020
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in tablet_interface.cpp:58
> This is still potentially crashy:
> if all clients remove their tablet support we would have a dangling pointer in m_tablets.
>
> Personally I would remove this delete q, and have the lifespan of TabletInterface managed up to TabletSeatInterface::removeTablet or TabletSeatInterface::~TabletSeatInterface()
>
> even if it has no resources.
or if we do want to keep the TabletInterface around till clients gracefully remove their side
we should have some sort of if (resourcesMap.isEmpty() && isRemoved) {delete q}
REPOSITORY
R127 KWayland
BRANCH
arcpatch-D26858
REVISION DETAIL
https://phabricator.kde.org/D26858
To: apol, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200318/4fe6b4a2/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list