D26858: Provide an implementation for the tablet interface

David Edmundson noreply at phabricator.kde.org
Wed Mar 18 15:56:55 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> tablet_interface.cpp:58
> +        if (resourceMap().isEmpty()) {
> +            delete q;
> +        }

This is still potentially crashy:
if all clients remove their tablet support we would have a dangling pointer in m_tablets.

Personally I would remove this delete q, and have the lifespan of TabletInterface managed up to TabletSeatInterface::removeTablet or TabletSeatInterface::~TabletSeatInterface()

even if it has no resources.

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D26858

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks, zzag
Cc: davidedmundson, zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200318/8b760a2e/attachment.html>


More information about the Kde-frameworks-devel mailing list