D28112: [WIP] Expose application menu via KWindowInfo

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in netwininfotestclient.cpp:281-319
> You have to change properties via xcb_change_property().
> 
>   void NetWinInfoTestClient::testAppMenuObjectPath()
>   {
>       ATOM(_KDE_NET_WM_APPMENU_OBJECT_PATH)
>       INFO
>   
>       QVERIFY(!info.appMenuObjectPath());
>   
>       xcb_change_property(connection(), XCB_PROP_MODE_REPLACE, m_testWindow,
>                           atom, XCB_ATOM_STRING, 8, 4, "foo\0");
>       xcb_flush(connection());
>   
>       waitForPropertyChange(&info, atom, NET::Property(0), NET::WM2AppMenuObjectPath);
>       QCOMPARE(info.appMenuObjectPath(), "foo");
>   }
>   
>   void NetWinInfoTestClient::testAppMenuServiceName()
>   {
>       ATOM(_KDE_NET_WM_APPMENU_SERVICE_NAME)
>       INFO
>   
>       QVERIFY(!info.appMenuServiceName());
>   
>       xcb_change_property(connection(), XCB_PROP_MODE_REPLACE, m_testWindow,
>                           atom, XCB_ATOM_STRING, 8, 4, "foo\0");
>       xcb_flush(connection());
>   
>       waitForPropertyChange(&info, atom, NET::Property(0), NET::WM2AppMenuServiceName);
>       QCOMPARE(info.appMenuServiceName(), "foo");
>   }

please get rid of '\0'

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D28112

To: cblack, #plasma, broulik, zzag, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200318/b7874758/attachment.html>