<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28112">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28112#inline-159394">View Inline</a><span style="color: #4b4d51; font-weight: bold;">zzag</span> wrote in <span style="color: #4b4d51; font-weight: bold;">netwininfotestclient.cpp:281-319</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">You have to change properties via xcb_change_property().</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">void</span> <span class="n">NetWinInfoTestClient</span><span style="color: #aa2211">::</span><span class="n">testAppMenuObjectPath</span><span class="p">()</span>
<span class="p">{</span>
<span class="n">ATOM</span><span class="p">(</span><span class="n">_KDE_NET_WM_APPMENU_OBJECT_PATH</span><span class="p">)</span>
<span class="n">INFO</span>
<span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">info</span><span class="p">.</span><span class="n">appMenuObjectPath</span><span class="p">());</span>
<span class="n">xcb_change_property</span><span class="p">(</span><span class="n">connection</span><span class="p">(),</span> <span class="n">XCB_PROP_MODE_REPLACE</span><span class="p">,</span> <span class="n">m_testWindow</span><span class="p">,</span>
<span class="n">atom</span><span class="p">,</span> <span class="n">XCB_ATOM_STRING</span><span class="p">,</span> <span style="color: #601200">8</span><span class="p">,</span> <span style="color: #601200">4</span><span class="p">,</span> <span style="color: #766510">"foo</span><span style="color: #bb6622">\0</span><span style="color: #766510">"</span><span class="p">);</span>
<span class="n">xcb_flush</span><span class="p">(</span><span class="n">connection</span><span class="p">());</span>
<span class="n">waitForPropertyChange</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">info</span><span class="p">,</span> <span class="n">atom</span><span class="p">,</span> <span class="n">NET</span><span style="color: #aa2211">::</span><span class="n">Property</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">),</span> <span class="n">NET</span><span style="color: #aa2211">::</span><span class="n">WM2AppMenuObjectPath</span><span class="p">);</span>
<span class="n">QCOMPARE</span><span class="p">(</span><span class="n">info</span><span class="p">.</span><span class="n">appMenuObjectPath</span><span class="p">(),</span> <span style="color: #766510">"foo"</span><span class="p">);</span>
<span class="p">}</span>
<span style="color: #aa4000">void</span> <span class="n">NetWinInfoTestClient</span><span style="color: #aa2211">::</span><span class="n">testAppMenuServiceName</span><span class="p">()</span>
<span class="p">{</span>
<span class="n">ATOM</span><span class="p">(</span><span class="n">_KDE_NET_WM_APPMENU_SERVICE_NAME</span><span class="p">)</span>
<span class="n">INFO</span>
<span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">info</span><span class="p">.</span><span class="n">appMenuServiceName</span><span class="p">());</span>
<span class="n">xcb_change_property</span><span class="p">(</span><span class="n">connection</span><span class="p">(),</span> <span class="n">XCB_PROP_MODE_REPLACE</span><span class="p">,</span> <span class="n">m_testWindow</span><span class="p">,</span>
<span class="n">atom</span><span class="p">,</span> <span class="n">XCB_ATOM_STRING</span><span class="p">,</span> <span style="color: #601200">8</span><span class="p">,</span> <span style="color: #601200">4</span><span class="p">,</span> <span style="color: #766510">"foo</span><span style="color: #bb6622">\0</span><span style="color: #766510">"</span><span class="p">);</span>
<span class="n">xcb_flush</span><span class="p">(</span><span class="n">connection</span><span class="p">());</span>
<span class="n">waitForPropertyChange</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">info</span><span class="p">,</span> <span class="n">atom</span><span class="p">,</span> <span class="n">NET</span><span style="color: #aa2211">::</span><span class="n">Property</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">),</span> <span class="n">NET</span><span style="color: #aa2211">::</span><span class="n">WM2AppMenuServiceName</span><span class="p">);</span>
<span class="n">QCOMPARE</span><span class="p">(</span><span class="n">info</span><span class="p">.</span><span class="n">appMenuServiceName</span><span class="p">(),</span> <span style="color: #766510">"foo"</span><span class="p">);</span>
<span class="p">}</span></pre></div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">please get rid of '\0'</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R278 KWindowSystem</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28112">https://phabricator.kde.org/D28112</a></div></div><br /><div><strong>To: </strong>cblack, Plasma, broulik, zzag, KWin<br /><strong>Cc: </strong>zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>