D27871: sftp: fix seekPos + file resuming when part file is of size 11

[Harald Sitter]

sitter added a comment.


  In D27871#623593 <https://phabricator.kde.org/D27871#623593>, @bruns wrote:
  
  > In D27871#623542 <https://phabricator.kde.org/D27871#623542>, @sitter wrote:
  >
  > > In D27871#622933 <https://phabricator.kde.org/D27871#622933>, @bruns wrote:
  > >
  > > > Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff the file where opened with O_NONBLOCK. All other seek errors are fatal.").
  > >
  > >
  > > I do not understand what that means.
  >
  >
  > Previously, EAGAIN was handled explicitly (although the implementation was wrong). Why is it fine to **not** handle it? This belongs in the commit message.
  
  
  But lseek does not use EAGAIN, does it?
  In any case, can't you edit the message to make it say what you think it should say? (if not I am sure sysadmins can give you magic powers)

INLINE COMMENTS

> bruns wrote in kio_sftp.cpp:1687
> qCDebug(), operator<<

We do that all over the place.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27871

To: sitter, ngraham, feverfew
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200309/6106bf22/attachment.html>