D27871: sftp: fix seekPos + file resuming when part file is of size 11

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Mar 6 19:17:52 GMT 2020


bruns added a comment.


  In D27871#623542 <https://phabricator.kde.org/D27871#623542>, @sitter wrote:
  
  > In D27871#622933 <https://phabricator.kde.org/D27871#622933>, @bruns wrote:
  >
  > > Can you also mention why errno == EGAIN does not have to be handled ("EAGAIN could only happen iff the file where opened with O_NONBLOCK. All other seek errors are fatal.").
  >
  >
  > I do not understand what that means.
  
  
  Previously, EAGAIN was handled explicitly (although the implementation was wrong). Why is it fine to **not** handle it? This belongs in the commit message.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27871

To: sitter, ngraham, feverfew
Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200306/aee332c6/attachment.html>


More information about the Kde-frameworks-devel mailing list