D26969: fix type namespace requirement

David Edmundson noreply at phabricator.kde.org
Fri Mar 6 13:20:55 GMT 2020


davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  This is rather horrible, but at the same time makes a lot of sense.
  
  One minor comment, but then, ship it I guess.

INLINE COMMENTS

> DBusHelperProxy.cpp:273
> +        QMetaMethod method;
> +        for (int i = metaObj->methodOffset(); i <= metaObj->methodCount(); ++i) {
> +            if (QLatin1String(metaObj->method(i).name()) != slotname) {

we could:

int offset = metaObj->indexOfMethod(slotname);

instead of a loop.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26969

To: sitter, apol, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200306/5f84aec2/attachment.html>


More information about the Kde-frameworks-devel mailing list