<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26969">View Revision</a></tr></table><br /><div><div><p>This is rather horrible, but at the same time makes a lot of sense.</p>

<p>One minor comment, but then, ship it I guess.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26969#inline-157627">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DBusHelperProxy.cpp:273</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QMetaMethod</span> <span class="n">method</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span class="n">metaObj</span><span style="color: #aa2211">-></span><span class="n">methodOffset</span><span class="p">();</span> <span class="n">i</span> <span style="color: #aa2211"><=</span> <span class="n">metaObj</span><span style="color: #aa2211">-></span><span class="n">methodCount</span><span class="p">();</span> <span style="color: #aa2211">++</span><span class="n">i</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="n">metaObj</span><span style="color: #aa2211">-></span><span class="n">method</span><span class="p">(</span><span class="n">i</span><span class="p">).</span><span class="n">name</span><span class="p">())</span> <span style="color: #aa2211">!=</span> <span class="n">slotname</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we could:</p>

<p style="padding: 0; margin: 8px;">int offset = metaObj->indexOfMethod(slotname);</p>

<p style="padding: 0; margin: 8px;">instead of a loop.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R283 KAuth</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26969">https://phabricator.kde.org/D26969</a></div></div><br /><div><strong>To: </strong>sitter, apol, davidedmundson, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>