D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfilefiltercombo.cpp:31
> +Q_DECLARE_LOGGING_CATEGORY(KIO_KFILEWIDGETS_KFILEFILTERCOMBO)
> +Q_LOGGING_CATEGORY(KIO_KFILEWIDGETS_KFILEFILTERCOMBO, "kf5.kio.filewidgets.kfilefiltercombo", QtWarningMsg)
>  

Err why don't you include kiofilewidgets_debug.h instead?

You're redefining what the generated file contains, here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200305/3a72e59b/attachment.html>