D27865: [KFileFilterCombo] Don't add inavlid QMimeType to mime filter

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looks good from a quick scan. If the content of the generated kio.categories files also matches what you expect, things are fine. Perhaps I would invert things and generate the header for kf5.kio.filewidgets.kfilefiltercombo and include that, instead of the manual definition in the C++ code. And do the ecm_qt_export_logging_category for kf5.kio.filewidgets instead, given this is not yet used.
  
  Meh, I really need to get to finish my prototype for T12741 <https://phabricator.kde.org/T12741>, which also brings the ability to define multiple categories per generated header, instead of just one. That should get more sanity into things.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27865

To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200305/79113379/attachment.html>