D29281: Deprecate defunct functions
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Jul 14 12:21:24 BST 2020
kossebau added a comment.
In D29281#675955 <https://phabricator.kde.org/D29281#675955>, @davidre wrote:
> This caused https://bugs.kde.org/show_bug.cgi?id=423003. I removed excluding the virtual method from the build in
> https://invent.kde.org/frameworks/krunner/commit/8f7ce559b84ee0c21de0256e6591793e4b95f411
Gah, my bad for not catching this in the review. virtual methods need to be wrapped by the BUILD variant in the header. See also https://api.kde.org/ecm/module/ECMGenerateExportHeader.html?highlight=virtual
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29281
To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: davidre, kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200714/96a4434c/attachment.htm>
More information about the Kde-frameworks-devel
mailing list