<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29281">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D29281#675955" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D29281#675955</a>, <a href="https://phabricator.kde.org/p/davidre/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidre</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>This caused <a href="https://bugs.kde.org/show_bug.cgi?id=423003" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=423003</a>. I removed excluding the virtual method from the build in <br />
 <a href="https://invent.kde.org/frameworks/krunner/commit/8f7ce559b84ee0c21de0256e6591793e4b95f411" class="remarkup-link" target="_blank" rel="noreferrer">https://invent.kde.org/frameworks/krunner/commit/8f7ce559b84ee0c21de0256e6591793e4b95f411</a></p></div>
</blockquote>

<p>Gah, my bad for not catching this in the review. virtual methods need to be wrapped by the BUILD variant in the header.  See also <a href="https://api.kde.org/ecm/module/ECMGenerateExportHeader.html?highlight=virtual" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/ecm/module/ECMGenerateExportHeader.html?highlight=virtual</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29281">https://phabricator.kde.org/D29281</a></div></div><br /><div><strong>To: </strong>alex, Plasma, broulik, davidedmundson, vkrause, meven<br /><strong>Cc: </strong>davidre, kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>